Repository navigation
feat(universal-cookie): basic implementation of universal cookie - #404
Conversation
- add opaque token to be able inject cookie object - add optional request cookie object into node_http service
|
pretty good. We planned on cookie being a service as |
|
@gdi2290 well the question where implementation of such service should be placed. This PR just allow you to inject any implementation of So to complete Cookies feature there is 2 possible option:
Both of these option still need to inject |
|
@laskoviymishka I can add this just for now if you need it sooner than later. Later I'll create a cookie service that would be the prefer method. If that works for you then I can merge it |
|
@gdi2290 this would be really great! Later, when cookie service will be created, i'll refactor my code and adjust it to prefered method, but for now these would work good at least for me 😅 . |
|
@gdi2290 @laskoviymishka |
|
Implementation still not completed, but you can see how it could work in PR sample |
|
Hi guys, we have been unable to implement cookies as yet. When we pass the COOKIE_KEY and COOKIE values through the providers on ExpressEngineConfig, both are undefined in dist/node/node_http.js. ORIGIN_URL and BASE_URL are however defined as expected. Following from the Angular2 Universal Starter repo, our main.node.ts file looks like this: Any ideas? |
|
Ok so it looks like these changes fixes the issue in src/node/node_http.ts line 65: and I can make a PR to that effect if it is of assistance? |
|
@veliancreate can you make a PR |
xzengCB
left a comment
There was a problem hiding this comment.
I don't see this in the ng2 universal
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Related to issues: #273, and aspnet/JavaScriptServices#66
This is pretty easy fix, just to enable possibility to integrate server request cookie
remove unused proxy imports from some test files
Currently cookies not handled, just abstract class provided.
Provided abstract class injected as optional parameter to node_http, so we could grab cookie string from it. It provide abiliti to inject this cookie object from server. Here is some sample boot-server, that i use with my aspnet prerenderer:
No